Skip to content
This repository has been archived by the owner on Aug 11, 2023. It is now read-only.

feat: Group and Admin Page Creation #43

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

C4RR0T02
Copy link
Contributor

@C4RR0T02 C4RR0T02 commented Jun 29, 2023

TODO

  • Other Group Pages

@qin-guan
Copy link
Member

Pls fix CI errors

@qin-guan
Copy link
Member

I think the path organization can be improved:

  • The /admin path is reserved for god-mode users, in this case users do not have God mode.
  • I think it would make sense for the all users to start from something like /@[institution] or /_/[institution]
    • This page would show the groups they are in
    • We can handle redirect from / later
    • For educators/owners, they get one extra button in navbar / somewhere they can use to create groups
    • This brings them to /_/[institution]/new or something similar
  • Groups itself will be at /_/[institution]/[group]
    • This means no one can have a group with the short name new lol
    • Updating group options will be at /_/[institution]/[group]/settings

Please let me know if this makes sense, thanks

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 29, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bd24ee8
Status: ✅  Deploy successful!
Preview URL: https://8c517963.np-inprove.pages.dev
Branch Preview URL: https://sherlena-group-dashboard.np-inprove.pages.dev

View logs

@C4RR0T02
Copy link
Contributor Author

C4RR0T02 commented Jul 5, 2023

I think the path organization can be improved:

  • The /admin path is reserved for god-mode users, in this case users do not have God mode.

  • I think it would make sense for the all users to start from something like /@[institution] or /_/[institution]

    • This page would show the groups they are in
    • We can handle redirect from / later
    • For educators/owners, they get one extra button in navbar / somewhere they can use to create groups
    • This brings them to /_/[institution]/new or something similar
  • Groups itself will be at /_/[institution]/[group]

    • This means no one can have a group with the short name new lol
    • Updating group options will be at /_/[institution]/[group]/settings

Please let me know if this makes sense, thanks

As mention to you we will work on this if we have the time to do so

@qin-guan
Copy link
Member

qin-guan commented Jul 5, 2023

@C4RR0T02 I don’t think it’s a good idea to push this further, it shouldn’t be hard to implement

@C4RR0T02 C4RR0T02 requested a review from qin-guan July 11, 2023 04:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants